On Sun, 2014-03-30 at 22:00 +0200, Johan Engelen wrote:
I find that code review takes *a ton* of time.
This is probably because your doing it properly :-) I have a much smaller set of red flags in C++.
I think we don't need to check everything, just setup your red flag list to a subset of things you're really good and keen on. If two or three parties run their particular bugbears over the code and are quick to report back with a low threshold then the developer can fail quicker and get things fixed quicker.
The evidence for getting high quality out of multiple low quality signals is clear to me. Get two or more people for each review but set the bar really low and set the speed really quick. That turn around speed is really important for keeping flow going.
Martin,