On Tue, Mar 25, 2014 at 11:39:51PM -0400, Martin Owens wrote:
On Tue, 2014-03-25 at 23:59 +0000, J.B.C. Engelen (Johan) wrote:
Inkscape is open source
IANABM*
I always thought Inkscape was more like a cake sale than open source. ;-)
You'll have to explain that one.
For fixing code, there should be some sort of timer which says that is code is in trunk via the process set up by the project, then it should be fixed if found defective by the original developer if found within 2 or maybe 6 months. Otherwise the code should be considered divorced from it's original writer.
As for policy regarding commit access; we don't do enough to encourage code review. Anything to encourage code review would be great, I don't even mind if I were downgraded to B level 'code must be reviewed before merge' status. Because really, it should be.
I like this. I'll even put my hand up to do some code reviews. Can we just turn code reviews on with our current tooling?
njh