On Thu, 2013-02-07 at 21:05 +0100, ~suv wrote:
The menu separator added in r12105/12106 looks great!
In the 'Text and Font' dialog though, the list of font families is currently out-of-sync with the font of the current selection: the inserted (duplicate) entries of used fonts at the top, and the separator item (listed as font 'separatoR') are not taken into consideration for the position of the selected/highlighted item in the list further down. Result: in the dialog, the hightlighted font family on the left and the preview at the bottom no longer match (preview is correct).
Would anybody miss the 'Text and Font' dialog now that we have the style selector in the 'Text' tool toolbar? I started the process of updating the 'Text and Font' dialog to match the Text toolbar but I have discovered that it is going to take quite a bit of work. For example the dialog font selector cannot handle font-family lists, nor does it have an entry box for typing in the name of a font. Both the toolbar and the dialog do mostly the same things but in quite different ways. If we keep the dialog, a helper class should probably be written that encapsulates the common functionality.
Tav