bulia byak wrote:
On Sun, 06 Mar 2005 10:54:32 -0800, Jon A. Cruz <jon@...18...> wrote:
The hardcoding shortcut was what happened to allow cutting previously. Getting rid of the 'naughty' code happened to get rid of that benefitial side-effect. So I just need to track down a proper way to allow that to happen. Just like with the toolbox heights, I'll replace the physical with some logical. The old height way was "set all toolbars to a minimum of XX pixels". The new height way is "set all these toolbox widgets to get the height desired by the largest". That's what I mean by physical versus logical.
You're right about vertical size, but I'm speaking about the horizontal length of horizontal toolbars. Previously they were very logical, i.e. "request 0 if attached or the natural size if detached". You removed that logic and now it's always the natural size, which is bad for attached toolbars.
No... they weren't "logical". They were physical. 'request 0' logically says "I don't need any size at all, so don't give me any". However, when docked, the layout takes over and says "too bad, I'm giving you this much. Deal with it".
:-)
The logic was in the programmer, not the code.
In this case, the code itself didn't say "only use what size is there". That properly belongs to the layout. Instead the widget itself was hardcoded with a value. The net effect appeared similar, but the logic was very different.
And guess what? I found the "proper" solution!
gtk_toolbar_set_show_arrow ()
" Sets whether to show an overflow menu when /toolbar/ doesn't have room for all items on it. If TRUE, items that there are not room are available through an overflow menu"
So there's a nice, HIG-ified automatic way to just get what we want.
The only problem is, that routine is for use on a GtkToolbar. We're not using the standard toolbar, but our own thing. :-(
Yes. It might be needed. But then again it might not. Once I track down a better way of handling that, then we'll see what's needed. Often things just start working better. It's just the transition from physical to logical that gets a little tough.
I'm not arguing for returning to physical sizes, I'm for returning to the clipping logic as described above.
Oh, yes. I realize that. I was just pointing out that the variable in question may not be needed. I did leave the setting in just in case it would be needed. But it might go away also.