I guess my argument would be more along the lines of: "then someone would use it" :-) Maintaining an API is a lot of work, and the stuff that we'd want to share between Inkview and Inkscape wouldn't necessarily be things that we'd want to maintain as an API.
--Ted
On Sun, 2012-08-05 at 20:57 +0100, Alex Valavanis wrote:
I would have thought it would be much more of a saving than that, and it doesn't strike me as being a difficult thing to do (see attached patch).
I haven't tested it, but if if really is only a 15 MB saving, then fair enough.
AV
On 5 August 2012 20:39, Johan Engelen <jbc.engelen@...2592...> wrote:
On 5-8-2012 21:13, Alex Valavanis wrote:
Hi All,
I'm not an expert on this kind of thing, but is there a reason why we don't distribute libinkscape as a shared library? At the moment, Inkscape and Inkview share a huge amount of code and they are both pretty big executables. Presumably, we'd save a lot of installation space with a shared lib.
Reason: it is a complete waste of time and energy to try to save 15 MB of disk space (or 5 M download size).
:) Johan
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Attachment: shared_lib.diff === modified file 'src/Makefile.am' --- src/Makefile.am 2012-04-14 13:50:00 +0000 +++ src/Makefile.am 2012-08-05 18:28:12 +0000 @@ -24,9 +24,9 @@ internal_GDL = libgdl/libgdl.a endif
+lib_LTLIBRARIES = libinkscape.la
noinst_LIBRARIES = \
libinkscape.a \ dom/libdom.a \ libcroco/libcroco.a \ libavoid/libavoid.a \@@ -39,6 +39,7 @@ libinkversion.a
all_libs = \
$(lib_LTLIBRARIES) \ $(noinst_LIBRARIES) \ $(INKSCAPE_LIBS) \ $(GNOME_VFS_LIBS) \@@ -211,7 +212,7 @@ # ################################################
# this should speed up the build -libinkscape_a_SOURCES = $(ink_common_sources) +libinkscape_la_SOURCES = $(ink_common_sources)
inkscape_SOURCES += main.cpp $(win32_sources) inkscape_LDADD = $(all_libs)
=== modified file 'src/extension/dbus/Makefile_insert' --- src/extension/dbus/Makefile_insert 2010-07-16 22:29:25 +0000 +++ src/extension/dbus/Makefile_insert 2012-08-05 18:28:23 +0000 @@ -57,7 +57,7 @@ # DBus Interface Helper Lib ############################
-lib_LTLIBRARIES = \ +lib_LTLIBRARIES += \ libinkdbus.la
libinkdbusincludedir = $(includedir)/libinkdbus-0.48/libinkdbus
Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel