-----Original Message----- From: Richard W.M. Jones [mailto:rjones@...43...] Sent: dinsdag 28 oktober 2008 16:24 To: Engelen, J.B.C. (Johan) Cc: tweenk.pl@...400...; inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] [PATCH] Fedora MinGW cross-compiling patch,version 2
On Tue, Oct 28, 2008 at 04:00:43PM +0100, J.B.C.Engelen@...1578... wrote:
Please, before committing this kind of patches to svn,
check the build
on linux *and* windows. Especially on windows for this
patch because
it involves adding a "#ifndef win32" clause around a whole file.
The problem here is that the compiler on Windows doesn't allow an empty translation unit?
With cross-compiling, we're still using gcc, so we won't catch this unless we compile with -ansi -pedantic-errors (? IIRC)
Empty translation units are not a problem, otherwise we could never write #ifndef __FILE_DIALOGIMPL_H__ #define __FILE_DIALOGIMPL_H__ at the start of any header file!
The problem is that now a whole file is excluded from windows builds by #ifndef WIN32, and this file defines a type needed by other files, hence: src/ui/dialog/ocaldialogs.h:153: error: 'FileType' was not declared in this scope
Dumb question I guess, but does your cross-compiler set WIN32?
I removed the #ifndef WIN32, now Inkscape builds again.