Hi,
I've written a patch, enclosed below, which uses relaytool to make gtkspell weak linked. In English, that means Inkscape will use it if it's available at runtime, but otherwise won't. It's like using dlopen, except that fewer code changes are required and it's generally a lot more convenient.
This exposed some issue that I am still trying to track down, of a crash deep inside aspell. I am not sure why this occurs, but I see the same problem with AbiWord. I am starting to wonder if this is another C++ ABI issue, because whilst the GCC documentation explicitly states that mixing two libstdc++ versions in the same image will work fine, in practice it apparently does not (or at least, I cannot see any other reason for the failure).
If anybody starts seeing crashes inside aspell with the current nightly builds, please let me know and maybe we can track this down.
The patch currently defines the relaytool macro in configure.ac directly, but it should be in acinclude.m4 - I'll fix this stuff before submitting it officially.
thanks -mike
Index: configure.ac =================================================================== RCS file: /cvsroot/inkscape/inkscape/configure.ac,v retrieving revision 1.40 diff -u -p -r1.40 configure.ac --- configure.ac 3 Apr 2005 05:39:59 -0000 1.40 +++ configure.ac 11 Apr 2005 12:37:16 -0000 @@ -384,7 +387,34 @@ dnl ****************************** dnl Unconditional dependencies dnl ******************************
PKG_CHECK_MODULES(INKSCAPE, gtk+-2.0 >= 2.4.0 libxml-2.0 >= 2.6.0 libxslt >= 1.0.15 sigc++-2.0 >= 2.0.3 gtkmm-2.4 $ink_spell_pkg) + +dnl define the relaytool macro +dnl RELAYTOOL("gtkspell", GTKSPELL_LIBS, GTKSPELL_CFLAGS, gtkspell_weak=yes) +dnl Will modify GTKSPELL_LIBS to include a call to relaytool if available +dnl or if not, will modify GTKSPELL_CFLAGS to include -D switches to define +dnl libgtkspell_is_present=1 and libgtkspell_symbol_is_present=1 + +AC_DEFUN([RELAYTOOL], [ + if test -z "$RELAYTOOL_PROG"; then + AC_PATH_PROG(RELAYTOOL_PROG, relaytool, no) + fi + + AC_MSG_CHECKING(whether we can weak link $1) + + if test "$RELAYTOOL_PROG" = "no"; then + AC_MSG_RESULT(no) + $3="-Dlib$1_is_present -D"lib$1_symbol_is_present(sym)=1" $$3" + else + AC_MSG_RESULT(yes) + $2="`relaytool --relay $1 $$2`" + $4 + fi +]) + +if test "x$ink_spell_pkg" != "x"; then + RELAYTOOL(gtkspell, INKSCAPE_LIBS, INKSCAPE_CFLAGS, ) +fi
dnl Shouldn't we test for libpng and libz? INKSCAPE_LIBS="$INKSCAPE_LIBS -lpng -lz" Index: src/dialogs/text-edit.cpp =================================================================== RCS file: /cvsroot/inkscape/inkscape/src/dialogs/text-edit.cpp,v retrieving revision 1.47 diff -u -p -r1.47 text-edit.cpp --- src/dialogs/text-edit.cpp 25 Mar 2005 01:55:24 -0000 1.47 +++ src/dialogs/text-edit.cpp 11 Apr 2005 12:37:16 -0000 @@ -362,17 +362,25 @@ sp_text_edit_dialog (void) GtkTextBuffer *tb = gtk_text_buffer_new (NULL); GtkWidget *txt = gtk_text_view_new_with_buffer (tb); #ifdef WITH_GTKSPELL - GError *error = NULL; - char *errortext = NULL; - /* todo: Use computed xml:lang attribute of relevant element, if present, to specify the - language (either as 2nd arg of gtkspell_new_attach, or with explicit - gtkspell_set_language call in; see advanced.c example in gtkspell docs). - sp_text_edit_dialog_read_selection looks like a suitable place. */ - if (gtkspell_new_attach(GTK_TEXT_VIEW(txt), NULL, &error) == NULL) { - g_print("gtkspell error: %s\n", error->message); - errortext = g_strdup_printf("GtkSpell was unable to initialize.\n" - "%s", error->message); - g_error_free(error); + +#ifndef libgtkspell_is_present + extern int libgtkspell_is_present; +#endif + g_print("one\n"); + if (libgtkspell_is_present) { + g_print("two\n"); + GError *error = NULL; + char *errortext = NULL; + /* todo: Use computed xml:lang attribute of relevant element, if present, to specify the + language (either as 2nd arg of gtkspell_new_attach, or with explicit + gtkspell_set_language call in; see advanced.c example in gtkspell docs). + sp_text_edit_dialog_read_selection looks like a suitable place. */ + if (gtkspell_new_attach(GTK_TEXT_VIEW(txt), NULL, &error) == NULL) { + g_print("gtkspell error: %s\n", error->message); + errortext = g_strdup_printf("GtkSpell was unable to initialize.\n" + "%s", error->message); + g_error_free(error); + } } #endif gtk_widget_set_size_request (txt, -1, 64);