Johan,
So for the test files, you want a couple test/examples per file for each effect? Such as a straightforward simple example and then the complex example, correct? Additionally, do you want a couple files utilizing lpe stacking and tests on groups to see if those have breakage again at some point?
It should be quick and straightforward to produce these, so please let me know exactly what you need.
Cheers, Josh
On 01/07/2009 03:41 PM, J.B.C.Engelen@...1578... wrote:
Ok, I have an idea: send me an SVG that uses the LPE you want to be present in 0.47 and I'll add that SVG to the testsuite. After three weeks or something, I'll disable all effects that don't have a testfile in the testsuite.
Does that sound reasonable?
LPE is very buggy, now the spiro LPE testfile crashes :-(
-Johan-----Original Message----- From: J.B.C.Engelen@...1578... [mailto:J.B.C.Engelen@...1578...] Sent: woensdag 7 januari 2009 23:22 To: buliabyak@...400...; inkscape-devel@lists.sourceforge.net; Anhalter42@...173...; maximilian.albert@...1439... Subject: Re: [Inkscape-devel] LPE cleanup
Hi all, yeah, LPE is a mess :-( I'm sorry I contributed to that :-(
Recently, I improved the conditional compile of unfinished effects. Now, the "test effects" are not compiled, unless one #defines LPE_ENABLE_TEST_EFFECTS. So for example, probably nobody here has the dynamic stroke LPE in their list, while I and jfb have. Have a look in /src/live_effects/effect.cpp around line 80 to see how to hide effects that are not finished.
I am very tempted to move *all* new LPEs since 0.47 to the disabled part. Moreover, every effect should have a test svg that tests the effect in the testsuite; with a couple of not so simple cases of the effect working properly.
cheers, Johan
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: woensdag 7 januari 2009 3:57 To: Inkscape Devel List; Maximilian Albert; Maximilian Albert Subject: [Inkscape-devel] LPE cleanup
Hi guys,
what if, as a first step towards 0.47, we clean up the mess
in our LPE
list - remove proofs of concept, hide those that only make
sense in a
tool, merge similar ones per our discussion, remove or fix
those that
crash? Can anyone who's more in the loop please make a list of suggestions?
-- bulia byak Inkscape. Draw Freely. http://www.inkscape.org
Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about
anything
Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the new SourceForge.net Marketplace. It is the best place to buy or sell services for just about anything Open Source. http://p.sf.net/sfu/Xq1LFB _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel