19 Sep
2013
19 Sep
'13
1:23 a.m.
On Wed, 2013-09-18 at 22:13 -0300, Vinícius dos Santos Oliveira wrote:
But... nobody gave me green light to merge commits. Anyway, I have commits right in the Inkscape repository and I wanna know if it's okay for me to do that (blocker issues with the merge are resolved).
Hey Vinícius,
We try to get to code review as best we can and where we each know the code base. We're all still learning different bits of this massive beast that is inkscape. Sorry I couldn't go through it all.
If you're happy with it, then merge it to trunk. The thing about trunk is 'with great power comes great responsibility' and thus if something goes wrong, you should have the time/intention to help fix it too.
Best regards, Martin Owens