On Sat, 5 Feb 2005 11:50:41 -0800, Kees Cook <inkscape@...62...> wrote:
1/5: compile cleanups only 2/5: test code changes only
Since these don't touch the code, they are OK (provided they work). Please apply.
3/5: core code changes for repr-action-test compiling
This is a trivial move, so if it compiles, it's OK to apply.
4/5: core code changes for repr-action-test behavior This changes when an undo session is released, down in simple-session. This lets repr-action-test pass its tests. The only caller to sp_repr_rollback is sp_document_cancel. sp_document_cancel isn't easily callable, since the three calls to it currently would only happen during repr tree breakage in the XML editor. I think this is safe.
I don't feel this is safe enough. You change not only rollback but also commit. At the very least, I want Mental to OK these changes. And in general, I would prefer a release with some failed tests than with broken core.
5/5: win32 file list updates This is just a final sync of all the above file changes, as seen by the win32 file list building tools.
This one is OK (so long as it compiles).
So, please apply all changes except 4, and try to get Mental's approval on 4.