W dniu 8 lutego 2010 04:48 użytkownik bulia byak <buliabyak@...400...> napisał:
Krzysztof,
I finally found time to test the new node tool. Overall it feels great, but of course I found many small and not so small things to fix :) #1 is my personal pet peeve, if you can't see it please just give me pointers to the code which passes events up and I'll have a look myself.
Thanks for all those tests. The code that handles events going to the canvas is in ui/tool/selector.cpp, but see below.
- Bug: Middle-button dragging and Shift-middle button zoom rubberband
still do not work. Are you using a mouse with a middle button to test? They work in Selector but not in Node.
Which revision are you using? For me (r9066 of trunk) they work correctly.
- Lost feature: node sculpting. Will you work on it, or do you want
me to work on porting it?
I will port it, but for now only one "sculpting profile" will be available. I would like to add enum support to preferences before introducing even more magic numbers to it.
- Lost feature: When rotating a handle with Ctrl, it now snaps to the original
position and 15 deg increments from that original position. The previous behaviour was: snap to origin, its opposite and perpendicular, to vertical/horizontal, and to 15 deg steps from vertical. This is much more useful because more often, I use Ctrl to snap it to vertical or some simple angle like 60 deg.
The old behavior was not consistent with selector tool and node transforms. All other constrained rotations snap to 15 deg increments from the original position. It is possible to make a handle horizontal by retracting it and then dragging it out with Shift+Ctrl.
- Performance:
I fixed this recently (r9061). There were two issues: 1. libsigc++ is much slower than I expected, 2. I wasn't dropping motion events when there were many of them in the queue. Right now the performance should be comparable to 0.47, though probably further improvements are possible.
- When mouseovering a node, it says "click to select" even if it is already
selected. I'd like to copy this from the old tool as well, which suggested various modifiers for dragging instead.
I reused the GIMP paradigm of only showing the modifier tips when the relevant modifiers are pressed. This way the tip has some chance of being displayed in its entirety, especially on smaller screens. I can add a note like "(more: Shift, Ctrl, Alt)" at the end to make the modifier actions more discoverable.
- UI suggestion: since the show/hide seltrans handles button belongs
to visualization, it should be moved to the right end of the controls bar, next to node handles and node outline toggles.
There is a very important difference in behavior when transform handles are on: clicking on a selected node switches between rotation and scaling (consistent with selector) instead of making it the only one selected. This is the reason behind putting the button in front of the controls bar.
The rest of points are valid and I'll start working on them right away.
Regards, Krzysztof