Excellent. I'd love to see that behavior as an option on the pencil tool's toolbar.
You say that, but to me, I'm really worried about the number of switches that inkscape is taking on. What icon could you use to explain a choice between "use old jaggedy line interpolation" or "use new smooth interpolation". IMHO, users just want the app to work right. The switches seem to be being used as an excuse by us to dodge hard design decisions.
I'd advise that we thoroughly test the new code, and see if we use any functionality by loosing the old interpolator, then if there's no significant loss, only gain, then replace the old with the new permanently!
Joel
On Thu, 2008-01-24 at 16:11 +0900, Bill Baxter wrote:
Excellent. I'd love to see that behavior as an option on the pencil tool's toolbar.
--bb
On Jan 24, 2008 4:05 PM, R M <hoverweasel@...400...> wrote:
Hi all, I've been having trouble getting lines smooth looking when drawing with the pencil tool. Looking at the code, it seems like a reasonable job of interpolation is being done, but it is done while the path is being drawn, so it can't base the interpolation on all the points drawn by the user.
I made some changes to do the interpolation of the entire path on button release:
Here is an example using identical mouse points and identical tolerances:
http://arcsin.org/temp/Screenshot-3.png
On the left, is the current way; on the right, is the path interpolated using the entire curve. Deferring interpolation decreases the number of knots created and improves (imo) the result appearance. The tolerance is still adjustable in the same way it is currently.
Here's the diff, which is only a demonstration, and in no condition to be actually used: http://arcsin.org/temp/diff
In order to make the final patch, i guess the questions are ... is the way i'm saving the points ok (or should i use std::vector, etc), should we forgo interpolating at all during drawing and instead just show the user a line path (which would greatly simplify the pencil-context code)? or do people want to retain the old behavior and create a new setting/tool.
regards, rob
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel