I should explain more clearly.
I agree that end users should not suffer a crash for us to find bugs. However, this exception is a low level check to see if the path is still a valid path. It's like the many other assertions Inkscape contains. I have argued against these things in the past, but I don't think we should remove/disable this one. It is actually used by Inkscape as well (I hate "g_assert" and love "throw", because it's possible to resolve a throw); some LPE's give invalid paths, and Inkscape notices this and stops LPE execution. Removing THROW_CONTINUITYERROR will mean that those LPEs will give faulty paths, and Inkscape won't notice it, giving faulty SVGs i think.
(otoh, I introduced these macros in 2geom to easily disable all of the exception throwing for a release........)
Cheers, Johan
-----Original Message----- From: Preben Soeberg [mailto:prsodk@...400...] Sent: zaterdag 5 september 2009 5:29 To: 'bulia byak' Cc: inkscape-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Win32 libs update request - was Re:Inkscape0.47pre2
-----Original Message----- From: bulia byak [mailto:buliabyak@...400...] Sent: 05 September, 2009 04:13 To: J.B.C.Engelen@...1578... Cc: prsodk@...400...; scislac@...400...; inkscape- devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] Win32 libs update request - was Re: Inkscape0.47pre2
On Fri, Sep 4, 2009 at 7:40 AM,
<J.B.C.Engelen@...1578...> wrote:
We should definitely not remove THROW_CONTINUITYERROR ! It means there is a real problem that Inkscape/2geom should not ignore. I think what causes the problem in this case is adding a line segment with 'invalid' points (like infinity). Perhaps adding a simple check for that in the callygr tool will fix this issue.
Does this exception lead to crashing? If yes we must definitely disable it for the release, and possibly reenable afterwards (if there's interest in fixing it properly). End users should not be forced to help us debug our bugs if there's any chance of crashing.
Yes, it causes crashes, and it makes the calligraphic tracing feature virtually unusable in Windows (when using the Wacom).