On Mon, 9 Aug 2004, Bob Jamison wrote:
This morning (Monday) I have been having trouble running CVS inkscape. Even after doing clean checkout/builds, the resulting inkscape does not show a GUI, even after 5 mins. Has someone modified the startup?
Last night I comitted some cleanup to livarot's Shape class (std::vector to replace ad-hoc reallocs), as well as some related signed/unsigned changes.
I should have held off on comitting the latter bit; I made a few variables unsigned which ought not to have been, and created some infinite loops in the process.
I cleaned up what I could last night; peter is working on the rest. Not that many files were actually affected and it was during a quiet period; if you do a CVS diff between noon yesterday and last night's commit, the int->unsigned changes should stand out.
The ones being used for loop iterators are OK (although they then require more signedness casts downstream); most of the rest should not have been touched at all. Like most of my large-scale changes it was automated; my normal regexp testing procedures seem to have failed me this time.
I did build and test it into normal startup, but since I'd been testing in valgrind all night and it was an unoptimized build I killed it before the GUI should have come up (I'd been used to waiting minutes).
What would have caught this earlier is if I'd captured the build stderr to a log and reviewed it before comitting -- in general I would have noticed that I'd created more warnings than I'd fixed, too.
I will do that in the future; sorry for the inconvenience.
-mental