Hi,
On Thursday 28 January 2010 17:18:24 Karlisson wrote:
Sure this patch is wonderful, long awaited! Congrats!
Thanks. It does need some more polishing though. (Also it currently adds objects to groups separately (if you are applying mask to more than one object, so it may not work exactly like you expect it to.)
There is a function that ungroups objects from groups (sp_item_group_ungroup) , but I have not seen any to group a list of objects into a group (it is done in selection-chemistry.cpp/sp_selection_group, but I'm not sure I can call it from sp_selection_set_mask directly... maybe little refactoring would help here... comments, anyone?)
Just to remember: there´s a bug that *should* be fixed as soon as possible. I don´t know if it occurs in mask too, but I´m sure it wasn´t there in 0.46, so, it's a regression.
Actually this bug is related to other parts of code. My patch modifies what is done when you are setting clip/mask whereas the bug is related to canvas editing. But I agree fixing this would be very useful (probably with some additional toolbar button/keystroke to temporarily disable clip/mask (not unset it) so the masked content could be easily edited?)
As Granjow pointed in comments, "Isn't this a matter of 10 minutes if you know the code?"
I'm afraid it would take more than 10 minutes even for an experienced Inkscape developer (unfortunately I'm beginner Inkscape developer) to fix this. Is there someone on this list willing to take a look at that?
Best regards, Martin Sucha