I reviewed both branches.
"Rotate copies" is reasonably OK, but "Mirror symmetry" needs fixes.
Intersecting with an infinite line by evaluating points at times 100000 and -100000 and intersecting with that line segment will not work for very large paths. You can't tell how long is 100000 and whether it's even large relative to the path because the coordinate system can be anything. Please use the line intersection functions, such as Line::intersect().
Best regards, Krzysztof
2016-03-15 2:21 GMT-07:00 Jabier Arraiza <jabier.arraiza@...2893...>:
Krzysztof, finaly Martin make a review for both branches. Ping me today if you want to make an extra review for any question.
Cheers, Jabier.
El lun, 14-03-2016 a las 22:11 -0700, Krzysztof Kosiński escribió:
2016-03-13 8:41 GMT-07:00 C R <cajhne@...400...>:
If someone could help us commit these few essential modifications, it would help tremendously!
I added this to my calendar for tomorrow evening. Please ping me directly off-list if it's not done by Wednesday.
Best regards, Krzysztof
Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel