2014-04-19 20:21 GMT+02:00 Martin Owens <doctormo@...400...>:
On Sat, 2014-04-19 at 19:20 +0200, Krzysztof Kosiński wrote:
Further note: the new method redrawDesktop() is incorrect, and this actually shouldn't cause a redraw. It only works because the relevant function is buggy and causes unnecessary updates. The correct way to do this is to call update() on Inkscape::Drawing with reset = STATE_ALL, and then call requestRedraw() on SPCanvas with an infinite rectangle.
It's a reposition of the original code. There's another call in desktop.cpp to that same call, is that incorrect? Should they be merged into your single proposed call replacement?
The original code was also not correct. If the semantic is "redraw absolutely everything", then yes, it should be replaced.
Regards, Krzysztof