On Mon, Feb 12, 2007 at 11:37:20PM -0800, Jon Phillips wrote:
On Mon, 2007-02-12 at 23:02 -0800, Ted Gould wrote:
that allows us to use non-local URIs in addition to local paths via Gnome-VFS by using GTK file chooser on the Open, Save ___, and Export dialogs. This means you can use webdav shares, samba mounts, sftp/ssh shares, now...basically, any backend that gnome-vfs supports, we should be able to use. So, in effect, one could work on files from a bluetooth phone filesystem (if so inclined ;).
I'm a bit concerned about this patch. Mostly it adds the ability to browse gnome-vfs filesystems with the file browser. But, the only file input method that supports using it is the SVG one. It seems very confusing that you can see files you can't open.
I'm not saying "back it out," as much as, this needs to be fixed before a release or we need to disable it.
Bryce, you might comment as well on the original implementation...
I swear for the life of me I can't track down the original patch in the tracker to cc the author. Otherwise, I should look into as well... ;)
Yeah, when I added gnome-vfs, I just stuck it directly into the svg export extension, since at that time my purpose was just to have a way to do 'inkscape http://what/ever.svg' from the commandline. That was pre-firefox, so whenever artists posted cool stuff to IRC, there wasn't a way to view it except download it, launch inkscape, and pull it in.
However, there's several things that could be changed for a more proper implementation.
First, the _load_uri() routine in svg.cpp should be moved up to a higher level (maybe to input.*?) It's been kept generic and there's nothing particular to svg files, so it should work fine with all other file types.
Next, all of the input extensions should be revised to use _load_uri() instead of calling fopen() or whatever directly.
Then, for balance would be to create an analogous _save_uri(), and update all the output extensions to use it.
Further, I've noticed that if you launch inkscape with a non-existant filename (e.g., 'inkscape foobar.svg'), it currently displays an error dialog; instead it ought to create a new empty document with that filename.
Bryce