Johan,
Thanks for the comments.
On Sun, 2014-03-30 at 21:50 +0200, Johan Engelen wrote:
On 27-3-2014 16:01, Tavmjong Bah wrote:
Hi all,
I have rewritten most of the style handling code in style.h and style.cpp to use real C++ classes. I would like you all to review the code and give feedback. The code is available at:
lp:~inkscape.dev/inkscape/style
Some quick comments about all the bitfield usage:
- style.h, lines135-
Don't use bitfields there. Simply use bool. Much less bugprone. I don't think there is any reason to use bitfields there.
Or, even better, get rid of them completely. They were not being used.
- style-internal.h
Have a look at the use of all bitfields there. A 1-bit bitfield to store some boolean value, I think is best replaced with a bool.
Done where it doesn't increase class memory size.
(can you run clang-format on the code? thank
I did a test. While some formatting is improved, it messes up other formatting. As it also makes diffing against previous code more difficult, I would prefer to wait on this.
Tav