On 2014-02-06 15:44 +0100, Tavmjong Bah wrote:
While mucking about the code I noticed that the same basic code to handle viewBox and preserveAspectRatio appeared in multiple files (8 times?) having originally been pasted directly or copied with some changes. Overtime the code was tweaked here and there.
I have created a new base class to handle viewBox and preserveAspectRatio and modified sp-root, sp-symbol, sp-image, sp-pattern, and marker to use the new class, resulting in a reduction of over 400 lines of code (yeah!). In the process, I've fixed a number of issues with using percentage based x, y, width, and height values.
Please let me know if you find any problems.
Stretched or squeezed bitmap images now (rev >= 13002) render according to the SVG 1.1 spec, but not to how Inkscape users expect it: the bounding box matches the expected dimensions, but the image itself appears to be displayed with 'preserveAspectRatio="xMidYMid"' (default for images in SVG 1.1 if 'preserveAspectRatio' is not specified).
Steps to reproduce: 1) launch current trunk (rev >= 13002) 2) import bitmap image (embed or link, doesn't matter) 3) stretch the image horizontally or vertically by dragging one of the scale handles 4) release the mouse button
Expected result in Inkscape: The embedded or linked bitmap image is scaled to match the new dimensions.
Actual result with rev >= 13002: The bounding box of the selected image has the expected dimensions, but the actual image content reverts to a preserved aspect ratio, as large as fits into the transformed bbox.
Changes of r13002 affecting other parts of Inkscape: - Bug #1278645 “image handling in sp-image corrupts EMF/WMF output” https://bugs.launchpad.net/inkscape/+bug/1278645
Related reports about the old (non-conformant) behavior: - Bug #924377 “wrong default value for image preserveAspectRatio” https://bugs.launchpad.net/inkscape/+bug/924377 - Bug #461467 in Inkscape: “Image scale saved incorrectly” https://bugs.launchpad.net/inkscape/+bug/461467 - Bug #616717 “Resized bitmap images are rendered differently by Firefox or Batik ('preserveAspectRatio' attribute not set)” https://bugs.launchpad.net/inkscape/+bug/616717
Note that adding an explicit 'preserveAspectRatio="none"' to the bitmap image currently doesn't help either - Inkscape trunk appears to lack support for this attribute yet (?). The only workaround with rev >= 13002 is to group the image (Ctrl+G), and then scale the group instead of the imported image, or to use preserved transforms (see preferences).
Regards, V