On Tue, 2016-05-03 at 00:43 -0700, Krzysztof Kosiński wrote:
I added some more information.
I think the icon clipping bug may be related to the use of SPIcon. If we can replace that with GtkImage, it might go away.
I fixed this in r14870. The icon clipping is due to wrapping the icon in a widget where the preferred width/height of the widget was calculated by adding the preferred width/height of the icon to the border width. By also adding the padding width the icons are no longer clipped.
I am not sure why we need to be concerned with border/padding widths. In a style sheet based framework, border/padding/margin should be taken care of automatically.
One thing I observed in tracking this problem down is that we have many ways to turn icons into buttons. We should try to unify these as we move to GTK3.
Tav