Carl Hetherington wrote:
On Thu, 15 Apr 2004, Ted Gould wrote:
On Thu, 2004-04-15 at 07:47, Carl Hetherington wrote:
I just committed a patch to allow save as PS/EPS on Win32. I'd be grateful if any Windows-ers could test it.
It looks like the fileTypes parameter to the FileOpenDialog and FileSaveDialog constructors is now not required. Perhaps it should be removed?
Cool! Thanks for the work. I think that parameter can go away also. I kept breaking the win32 build when changing that dialog - so I was trying to be conservative because I couldn't test the win32 compile. I believe that parameter can go away also.
Sounds good. Please make certain, though, that filedialog.cpp and filedialog-w32.cpp both follow the filedialog.h API, so as not to break it on Unix.
OK. I'm a bit confused about the Import dialogue, though. Is it right that on Linux the menu only offers "SVG", and no other types? ATM, the Windows version offers "SVG files" and "Image files" as selection options.
Notice that for Import, even on Windows, the GTK file open dialog is used. Really, since on Win32 we are using the windows native file open dialog for SVG, we should be using the same for Import. I didn't make this change, because I thought that if we could wait until GTK 2.4, the new file dialogs would be good enough that we would not need two different implementations.
One thing to keep in mind, is that we need to migrate from "filename" to Mental's URI model. This is important for (1) portability and (2) SVG spec compliance. Currently on Windows, if you import an image, the SVG file will quote the path in Windows format. Something like:
<image .......blah .... filePath="c:\path\to\the\file"/>
....which is obviously unacceptable, and useless on non-Windows boxen. Eventually we will need several things:
1. The file dialogs return URIs 2. The sp_module_open() calls handle URIs too 3. All of the resource-handling modules use URIs too, like for markers, icons, clipart, etc.
Bob