On Dec 12, 2010, at 2:38 PM, Krzysztof Kosiński wrote:
W dniu 12 grudnia 2010 18:25 użytkownik Jon Cruz <jon@...18...> napisał:
To summarize what you should be able to see, we had bad access all over the place before the refactoring; now, however, some of it is more explicit and easier to spot and thus will be easier to fix.
Okay, this does make some sense. However, I would like to see those methods marked with a warning saying that they should not be used outside of the SP tree.
Yes, you can add TODO comments if you want. That would be helpful.
But what would be most helpful is looking over to figure out the clean ways to change the code so that such access is no longer exposed to begin with. Comments and warnings can often be ignored over time. Our bounding box functions are a good example. They had been deprecated, but people still have not stepped up to help clean up the use.