2013/9/9 Jabiertxo Arraiza Cenoz <jabier.arraiza@...2893...>:
Thanks for the review Krzysztof.
Anybody confirm about first point? If is wrong with no manual XML modification...
It should be called "Last applied", but in this case it should be implemented in a significantly different way. You should store the last shape e.g. in a static variable whenever a shape is applied. Using the first effect in defs is not very useful.
Second point. Any body can help me?
Use strcmp().
Third point is bad because i like the strokes like the original, I dislike force the style to black and always filled. If is posibol to continue with it i need a better name...you are welcome.
Point 3 is not about what the code does, it's about how it is written. You should not set a variable to true, then reset it back to false when you don't find something.
Regards, Krzysztof