I'm concerned about reports like these of compatibility issues when using git submodules.
I haven't used git submodules myself but I have used similar functionality in other VCS's in the past and had similar experiences with them causing problems integrating with other tools, and needing more manual attention and management than expected.
I suspect it will be easier for especially new devs if we stick with external dependencies for what can be external, and copied-in code for whatever can't, and focus on minimizing the latter and maximizing the former as much as possible.
Bryce
On Mon, Jul 17, 2017 at 03:47:58PM +0100, Alex Valavanis wrote:
I attempted to sync the code for my other project (launchpad.net/qwwad) from github to Launchpad so I could build a PPA from a source recipe... it seems that git submodules were ignored in the import!
AV
On 17 July 2017 at 15:10, Tobias Ellinghaus <houz@...173...> wrote:
Am Montag, 17. Juli 2017, 14:24:21 CEST schrieb Sylvain Chiron:
Le 16/07/2017 à 13:09, Alex Valavanis a écrit :
This would also be highly desirable, but we should ensure that Inkscape can still build on systems that don't support submodules.
Why? What can be a system that doesn’t support submodules? Aren’t there managed by Git?
"git archive" doesn't include submodules, so anything that uses a tarball generated from that will miss parts of the sources.
-- Sylvain
Tobias
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel
Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel