Quick note, this thread (after my message) is to be taken into off-list territory. Thank you!
Cheers, Josh
On Sun, 2010-07-04 at 09:55 +0200, Krzysztof Kosiński wrote:
W dniu 4 lipca 2010 08:29 użytkownik Jon Cruz <jon@...18...> napisał:
Basically this issue is very similar to that encountered with cleaning up the Y-axis inversion. On the surface it might seem like a very simple job. However once it gets looked into, the details stat to crop up all over that reveal the scope of work to be far more than one might initially guess.
I don't want to be overly critical but so far the changes amount to mechanical replacement of "return_type sp_foo_method(SPFoo *, args...)" with "return_type method(args...)" and replacing "struct SPFoo" with "class SPFoo". This includes deprecated methods like sp_item_invoke_bbox_full with NRRect arguments. It would be more useful to identify a few places in the code with a dependency on GObject and rewrite them to eliminate that dependency.
Three other problems:
- Why are sp_foo_method left commented out at the bottom of the headers?
- Abhishek's changes use tabs instead of 4 spaces.
- New methods do not follow coding guidelines (should be camelCase
instead of lowercase_with_underscores).
Regards, Krzysztof
This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel