
25 May
2005
25 May
'05
4:13 p.m.
On 5/25/05, MenTaLguY <mental@...3...> wrote:
It seems to be refactoring the wrong pieces to me. I'd like to stick with strings or GQuarks to identify dialogs. There's no reason to tie dialogs to verbs directly.
But they are already tied to them directly. A verb is a non-optional parameter of a Dialog constructor. It's used for building the title bar string from the verb string and its shortcut, if any. I don't see any problem with that, and it's much better than duplicating the title in the dialog code (which lead to discrepancies, no shortcut display, extra work for translators etc).
So I'm for Bryce's suggestion. You create a dialog, create a verb for it too (even if it's not in menus).
--
bulia byak
Inkscape. Draw Freely.
http://www.inkscape.org