On Jul 24, 2011, at 3:24 PM, Krzysztof Kosiński wrote:
2011/7/24 Joel Holdsworth <joel@...1709...>:
As you say gdl does use stock icons, but I'm sure everyone would welcome it being modernized to support whatever new scheme has replaced them.
+1 It's better to add code to use themable icons to GDL, rather than using the old stock items mechanism, which is going to be removed anyway after GDL gets this functionality.
By the way, I have an idea: since we create an icon disk cache anyway now, why not create the cache in a freedesktop.org-compliant icon theme layout and then simply use gtk_icon_theme_append_search_path() on it? This would make roughly 60% of the code in icon.cpp redundant, as we could use Gtk::Image instead of SPIcon.
That wont work.
It breaks the load order. We want to have our internally generated icons have last priority, not first.
*However* the Gtk::Image vs SPIcon issue is a slightly different one. They are not tied one-to-one.