Re: [Inkscape-devel] patches for the bughunt waiting for some testers

On 14-1-2014 21:39, insaner wrote:

very trivial patches to test: https://bugs.launchpad.net/inkscape/+bug/1171109 comment #19

Thanks for your work. Could you fix these things first? - don't use tabs *ever* in our source code - there is no reason to use "gboolean" unless a function specifically wants it, and even then I would not to use it (in case of pointer or reference to a gboolean, then of course you _should_ use gboolean), so please use "bool" (perhaps rename "fix_ids" to "fix_clashing_ids") - no need to do "if (elem", as elem is guaranteed to be non-null there (see first line of function). It is confusing to repeat the check.

thanks, Johan