Jon A. Cruz wrote:
So you've masked a symptom by layering on workarounds. However you did not actually fix a bug, and introduced several regressions and additional bugs.
That can actually be said of the code I removed. It was a very elaborate wokraround for something that should be fixed properly (by properly, I mean in much fewer lines of code). I did not introduce any workarounds. I have also isolated the tiling bug and will commit a fix in a few hours.
Oh, and setting a breakpoint to determine a function is not used DOES NOT WORK. You *MUST* search the codebase for references.
Except it was a static function
(BTW, the same problem scenario existed for breaking the whiteboard. You didn't have a test configuration with that code endabled, so you did not notice when you broke the whiteboard).
In the bug comment about that breakage on Launchpad I already explained that I didn't break Whiteboard (or Whiteboard dialogs to be precise): it was already broken for a very long time. I modified the build system to get rid of link order issues, and a few left-over files re-entered the build. One of those files even contained a syntax error and nobody noticed that. It also had references to nonexistent object members and methods.
Regards, Krzysztof Kosiński