Some time ago I reported (and fixed) a duplication of strings in the unused code in src/ui. Now I discovered that the icons are also duplicated: in share/icons, alongside icons.svg, each icon is also in its own file. Bryce, can you please remove those duplicated icons because:
- I'm in principle against tearing icons.svg into pieces, as I explained some time ago in a discussion here. This will slow down program loading (parsing lots of small files is much slower than parsing a single big file) and make editing less convenient. Another reason is that the separate SVGs will be significantly larger in the total filesize than the single file (and thus even slower to load) because in the single file, many icons with repeating elements use clones which save a lot of space and work faster. With separate files this is impossible.
- People are already, and will be in the future, terribly confused as to which file is the real source for an icon.
- The duplicate icons are already getting out of sync because icons.svg is updated from time to time.
It would be nice to have this fixed before the release.