On Sat, Mar 22, 2014 at 05:42:34AM +0100, Krzysztof Kosiński wrote:
2014-03-21 23:25 GMT+01:00 Johan Engelen <jbc.engelen@...2592...>:
Ouch..... It'd be great if some people could work on at least getting configure to work with -Werror.
-Werror should NEVER be enabled by default, as it is equivalent to explicitly disabling forward compatibility with compilers and libraries.
- The compiler might add a new warning, and it so happens that
existing code triggers it. Build broken. 2. An external library we're using might deprecate a function. Build broken. 3. An external library might add warning-generating code to one of its headers. Build broken.
In other words, -Werror should only be enabled when someone explicitly requests it in configure. Only specific warnings should be converted to errors.
If it helps, I'm not against having -Werror set in the codebase at this particular time, since we're trying to focus the project on QA more tightly than usual. I do agree we should not ship actual packages that have this specified though; we don't want to make it any harder for users to get up and running.
Bryce