On 2013-06-12 02:06 +0100, Martin Owens wrote:
On Wed, 2013-06-12 at 01:17 +0200, ~suv wrote:
r12367 no longer crashes AFAICT.
Blubber! I've set the icon to 'remove' instead of 'gtk-remove' but with no list online for default icons in gtk and a very incomplete list of icons in the Ubuntu themes... It's trial and error time.
Let me know if it works, it does on Ubuntu.
Not sure if you misread my earlier message?
- Revision 12364 ("Fix new bug with No-Marker having no icon, use Stock GTK::Remove icon for No-Marker.") introduced the crash (regression) when opening the 'Fill & Stroke' dialog, if e.g. the stock GTK+ icon theme 'hicolor' is used (or no icon theme is explicitly defined at all).
- Revision 12367 ("Change back to using NULL and fix windows theme error by checking") works without crash - independent of the icon theme used.
- Revision 12369 ("Use 'remove' instead of 'gtk-remove' for theme.") also works without crash, no matter which icon theme is used.
Usability issue with the current solution:
Depending on the desktop (or GTK+) settings, neither of the two later revisions (12367, 12369) displays an icon (or a fallback label) in the marker selector menu though [1]:
Without an icon (or label, tooltip or whatsoever) - how do you tell (new) users how they can remove a marker once it has been set? There is nothing obvious in the popup menu which would indicate how to reset the marker to 'None', unless one happens to notice that the row above the top-most listed symbol in the popup menu displays a small (or even tiny) highlighted (empty) stripe if hovered, and in fact is the active menu entry for 'No marker'.
Just wondering: 'gtk-remove', or 'GTK_STOCK_REMOVE' does exist (even in the stock icon theme), and seems to work just fine elsewhere in Inkscape's dialogs (e.g. to remove a layer, or a live-path-effect). Why not in the marker selection menu in Fill & Stroke?
----- [1] tested & confirmed on OS X 10.7.5 with gtk icon theme explicitly set to 'hicolor', as well as with an empty 'gtkrc' file -> fallback to stock items/theme