J.B.C.Engelen wrote:
Hi Krzystof,
Did you see Ted's email? I have the same concern and am going to revert your change.
Johan
Sorry for the lag. After my modification inkscape_version.h wasn't generated at all, and the build failed because it was used in menus-skeleton.h.
I want to get rid of inkscape_version.h in favor of a mini-library that contains the version string, obtainable using a simple function This wouldn't require a sizable portion of Inkscape to be recompiled whenever the version changes - only a recompile of one trivial file and a relink would be needed. We could then have the SVN revision number in every binary. This would help out with testing nightly builds, because we sometimes couldn't reproduce a bug that wasn't there because it was fixed in the next SVN revision.
The mini-library design has a drawback - namely that the version cannot be incorporated into static strings. However, this only affected the preferences-skeleton.h and men-skeleton.h. Those files don't need a version, because the XML fragment is not a file - it is internal data, so it just doesn't make any sense to have the version number there. Probably I should have commented on this more in the SVN commit log.
Regards, Krzysztof Kosiński