On Wednesday 13 July 2005 20:31, Bryce Harrington wrote:
On Wed, Jul 13, 2005 at 01:51:21PM -0400, mental@...3... wrote:
Quoting Craig Bradney <cbradney@...242...>:
On a side note re the #ifdefs, how do you handle platform or OS specific code? Makefiles that include or exclude particular versions? Some very specific ifdefs? or isnt anything required?
The platonic ideal (which we don't necessarily achieve) is:
write as little platform-specific code as possible
agressively use portable library facilities in favor of rolling our own stuff
hide the rest behind OS-neutral interfaces (e.g. tables of function pointers or abstract base classes) which won't require #ifdefs in client code
make things configurable at run-time, not compile-time
do the rest (e.g. calling chosen initialization functions, or extracting data from certain fields) with extremely specific #ifdefs (one or two lines of code each)
Fwiw, it is possible to do testing of compilation of platform-specific code using 'cross-compilers'. I do this for NFSv4 but haven't done it for Inkscape (I figure its a lower priority since it's probably unlikely to generate as much interesting data as other tests we could run).
Yeah.. assuming you use the same compiler on all platforms, and same library loading routines and signal handling.
I think we will follow #3 a lot.. until the move to Qt4 which is awhile away.
Thanks for the tips.
Craig