On Apr 13, 2009, at 8:25 AM, bulia byak wrote:
Krzysztof,
In my testing the changes actually fixed some problems. What I did was to remove a lot of the caching system, and replace it with adding built-in icons (gtk_icon_theme_add_builtin_icon).
Purely from your description, this may be a violation of the refactoring freeze. Is there any specific user-visible bug you're fixing or functionality you're adding? If not please revert this for now regardless of whether it was the right thing to do or not, because we agreed to not do any more refactoring until the release.
I'll take care of this.
It seems clear that on the machine Krzysztof is testing he is not seeing the same problems. So he just doesn't have enough test points up there.
However, I did see at least one user-visible bug fixed by the batch of changes. So it makes sense for me to take care of this, since I have at least one system showing the problem (my OS X laptop) and I can observe the bugs before a fix and observe that after a fix the bugs go away without introducing more.