Hi, ====== Also, I am not familiar enough with the Inkscape codebase to know what to do with the very old looking SPTag stuff, which is why it isn't in my branch yet. If anyone wants to take a look and advise me on how to refactor this to make it work, the tag stuff is here: http://sta.sh/01etufm3jqvt (seriously, what the heck is an SPObjectClass? is that some sort of impls thing?) ======
sp_object_class->build = sp_tag_build; sp_object_class->release = sp_tag_release; sp_object_class->write = sp_tag_write; sp_object_class->set = sp_tag_set; sp_object_class->update = sp_tag_update;
Create virtual methods out of them.
class SPTag : public SPObject { virtual void build(...); ... };
Have a look at their declarations in SPObject.
sp_tag_init(SPTag *tag)
That's the constructor.
if (((SPObjectClass *) tag_parent_class)->write) { ((SPObjectClass *) tag_parent_class)->write(object, doc, repr, flags); }
That's a call to SPObject::write(object, doc, repr, flags);
sp_tag_class_init(SPTagClass *klass) sp_tag_get_type()
Throw them out.
If the process is still unclear, don't hesitate to ask!
Regards, Markus
-----Ursprüngliche Nachricht----- Von: liamw [mailto:inkscapebrony@...400...] Gesendet: Montag, 21. April 2014 21:25 An: inkscape-devel@lists.sourceforge.net Betreff: [Inkscape-devel] Merge in certain Ponyscape features
Many of the developers are probably aware of a popular fork of Inkscape called Ponyscape.
If you don't know of it, here are the extra features it offers: • Inverse clipping (clearly I'm not going to merge this in) • Objects dialog (http://sta.sh/0zb66ec8hyk ) • Tags dialog (selection sets http://sta.sh/01n137vphezw ) • Power stroke point control dialog (activated by shift+clicking width points http://sta.sh/01s1vyyazw8k ) • CubicBezierSmooth Power Strokes (http://sta.sh/0232eheuvzn0 ) • UI enhancements (for example https://bugs.launchpad.net/inkscape/+bug/1310688 ) • 5 new path effects ◦ Attach Path (there is a great tutorial on this by R4inbowR4ge here http://youtu.be/5o5P0897vb8 ) ◦ Bounding Box (...clearly you know what this one does, right?) ◦ Ellipse by 5 Points ◦ Fill Between Strokes (obsoleted) ◦ Fill Between Many (http://sta.sh/0mze2vk449o )
Path effects gallery: http://sta.sh/2257tq53v5kb
My plan is to get (most) of these features merged into trunk to keep them from bit-rotting away. I have created a branch here at Launchpad: https://launchpad.net/~inkscapebrony/inkscape/inkscape which addresses the majority of these features.
I've also fixed this: https://bugs.launchpad.net/inkscape/+bug/1290573 and this: https://bugs.launchpad.net/inkscape/+bug/1290573 (AFAIU neither have been fixed in trunk)
I'm asking for a little review—and possibly some feedback?—on the new features in the branch.
Also, I am not familiar enough with the Inkscape codebase to know what to do with the very old looking SPTag stuff, which is why it isn't in my branch yet. If anyone wants to take a look and advise me on how to refactor this to make it work, the tag stuff is here: http://sta.sh/01etufm3jqvt (seriously, what the heck is an SPObjectClass? is that some sort of impls thing?)
-- View this message in context: http://inkscape.13.x6.nabble.com/Merge-in-certain-Ponyscape-features-tp49702... Sent from the Inkscape - Dev mailing list archive at Nabble.com.
------------------------------------------------------------------------------ Start Your Social Network Today - Download eXo Platform Build your Enterprise Intranet with eXo Platform Software Java Based Open Source Intranet - Social, Extensible, Cloud Ready Get Started Now And Turn Your Intranet Into A Collaboration Platform http://p.sf.net/sfu/ExoPlatform _______________________________________________ Inkscape-devel mailing list Inkscape-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/inkscape-devel