On Tue, 2009-09-01 at 05:00 +0000, Nicolas Dufour wrote:
De : Ted Gould <ted@...11...>
À : Nicolas Dufour <nicoduf@...48...>
I confirm it was created for translations. And it is still in the trunk
(http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape/trunk/src/ui/di...).
Could someone (Jon, Bulia?) re-enable it in POTFILE.in so that the presets are translatable again?
I can't really look at this now as my laptop is in for repair, but I'd have to say that I'm a little concerned about an ...h file that isn't included anywhere. There's probably a better fix.
Yes, probably. I used a .h file because that's the way filters are also translated, and it was easy to set up. If .h is confusing in this case, we could find another file extension.
Okay, so looking into this a little, here's my understanding. (please correct me if I'm wrong).
In the preferences-skeleton.h there is a set of entries that correspond to the presets for the calligraphy tool. These entires contain user visible strings in them, for instance "Drop pen". Those entries are then manually copied to src/ui/dialogs/calligraphic-presets.h which gets picked up by gettext so that they get translated.
I guess the problem I see here is that there are user visible strings in the preferences file. I can't come up with a hard and fast reason that it's bad, but it definitely feels wrong. All the other asset based things filters, markers, etc. are in independent files. It seems like these should be as well. (that way we can have "Nicolas' pen pack" in the future also)
But, shorter term. I think that solution is to mark the strings in preferences-skeleton.h as translatable. Does anyone have issue with that?
--Ted