My upcoming text proposal will likely include some UI improvements for the text dialog and toolbar, so I didn't want to go too far with the bug fix. What the fix did allow me to do was get a feel for the code before I make the proposal ;)

Gail

bulia byak wrote:

On 3/24/07, Gail Banaszkiewicz <gbanaszk@...1686...> wrote:

My first bug is done and ready to go! It seems that I can't actually
upload my patch as an attachment to the bug itself, so mental suggested
creating a new entry in the patch tracker. Because I have never had a
need for patches in the past, this is the first one I've made. As such,
I'd like to have somebody double check that it worked ok before I
officially upload it.

http://gbanaszk.oasis.nexus.carleton.ca/SummerOfCode/patch-bug1679367.txt

Thanks, works ok so I committed it and closed the bug.

Actually it works a bit unintuitively in that it requires that one
presses Apply to have any effect, but oh well, that's the problem with
the entire dialog. Let's work on the toolbar to make it richer and
more usable so that the dialog is needed less often.