On Mon, 2009-02-09 at 10:37 -0800, Krzysztof Kosiński wrote:
J.B.C.Engelen wrote:
Did you see Ted's email? I have the same concern and am going to revert your change.
I want to get rid of inkscape_version.h in favor of a mini-library that contains the version string, obtainable using a simple function This wouldn't require a sizable portion of Inkscape to be recompiled whenever the version changes - only a recompile of one trivial file and a relink would be needed. We could then have the SVN revision number in every binary. This would help out with testing nightly builds, because we sometimes couldn't reproduce a bug that wasn't there because it was fixed in the next SVN revision.
The mini-library design has a drawback - namely that the version cannot be incorporated into static strings. However, this only affected the preferences-skeleton.h and men-skeleton.h. Those files don't need a version, because the XML fragment is not a file - it is internal data, so it just doesn't make any sense to have the version number there. Probably I should have commented on this more in the SVN commit log.
Well, simply put those aren't only internal data, because they get written out to the filesystem. Basically that's the template data that gets written. So we need the version number in them in-case we need to make incompatible changes for some reason.
--Ted