Kees Cook wrote:
On Mon, Feb 28, 2005 at 10:53:13PM -0800, Jon A. Cruz wrote:
So... all the SP_ICON_SIZE_* defines are about to dissapear, and their use should be replaced with the logical GTK_ICON_SIZE_* defines in many places. In many other places, hardcoded sizes should just dissappear.
I'm pretty sure that gtk_icon_size_* is an enum, rather than sizes. I tried to do this a while back. :)
Yes, GTK_ICON_SIZE_* are in an enum... but that's why they invented reinterpret_cast<>
:-)
Seriously, though, getting to an enum of logical sizes is a much better way to go. However, it does require a complete rework of icon.cpp. Of course, that's what I went and did. :-)
Now I'm just tracking down the callers who are not sending in proper stuff.
BTW, I believe that our main cause of fuzzy stock icons is from asking GTK+ to give us icons for buttons, but then placing them in a toolbar. If we ask for either the large or small toolbar versions, the default stock icons come in unblurred. That's probably due to there only being exact-sized versions for those in toolbar and menu sizes.