Having extra patches checked in seems an odd way to have a reproducible build since I'm used to:
1) Checkout source tagged for a release 2) Build, package
, but since I'm the packager, I'll do "1.5) add extra anti-crash stuff" .
Thanks, John
On Wed, Apr 16, 2008 at 3:05 AM, rygle <pittos@...1208...> wrote:
Hi John,
It's really up to the packagers of the Mac version whether they include the patch. The Windows version has about 9 patches that didn't get integrated into the main 0.46 branch code before release, and I'm not sure whether they have yet. The patches sit in /packaging/{platform}/patches.
If the patches have been in trunk for a while with no complaints, I don't think they need to sit in the patches directory forever, but Bryce and some others did have reservations a while back about keeping some platform specific stuff separate until well tested. Bryce asked us to put patches in the directory above.
Thus, even though patches might not be properly in branch, it shouldn't stop anyone applying those patches to the 0.46 code and building an 0.46 release for OS X 10.3. You just have to make sure that the patch applies cleanly to the branch code, as trunk and branch can differ a little.
Cheers,
Rygle.
John Faith wrote:
...is it possible to commit the patch to the 0.46 branch so that the OS X
10.3 release can move forward?