On Sat, Mar 29, 2008 at 11:08:44PM -0700, Jon A. Cruz wrote:
libgdl/gdl-dock-item.c:276: warning: assignment from incompatible pointer type
This looks like a legitimate bug: there shouldn't be a gpointer argument.
Btw, where does this source come from? I don't see this issue in gdl either v0.7.11 or svn head.
libgdl/gdl-dock.c: In function 'gdl_dock_dock_request': libgdl/gdl-dock.c:847: warning: comparison between signed and unsigned libgdl/gdl-dock.c:850: warning: comparison between signed and unsigned libgdl/gdl-dock.c:854: warning: comparison between signed and unsigned libgdl/gdl-dock.c:857: warning: comparison between signed and unsigned
These are inside a `if rel_x > 0 && rel_y > 0 && ...' block, so treating rel_x and rel_y as unsigned happens to be the right thing here.
To address this warning while at the same time reducing the chance of int overflow, I suggest changing `rel_x = x - a->x; if rel_x > 0 && rel_x < a->width' to `if x > a->x && x < a->x + a->width { guint const rel_x = x - a->x;'.
(This one OTOH is in upstream, at least in v0.7.11.)
libgdl/gdl-dock-item-grip.c: In function 'gdl_dock_item_grip_expose': libgdl/gdl-dock-item-grip.c:147: warning: assignment from incompatible pointer type libgdl/gdl-dock-item-grip.c:150: warning: passing argument 2 of 'gdk_draw_rectangle' from incompatible pointer type
The above two look fixable by changing bg_style to type GdkGC*.
libgdl/gdl-dock-paned.c:568: warning: comparison between signed and unsigned libgdl/gdl-dock-paned.c:573: warning: comparison between signed and unsigned libgdl/gdl-dock-paned.c:577: warning: comparison between signed and unsigned
Much the same problem/solution as above.
pjrm.