-----Original Message----- From: inkscape-devel-bounces@lists.sourceforge.net [mailto:inkscape-devel-bounces@lists.sourceforge.net] On Behalf Of Bob Jamison Sent: zondag 29 juni 2008 22:34 To: Engelen, J.B.C. (Johan); inkscape Subject: Re: [Inkscape-devel] [Lib2geom-devel] pathparsing -nartbpath optimization?
Hi all,
Maybe having the closing segment explicitly stated is legacy, left over from storing all SPShape objects as curves?
In NArtBpath, the closing segment is always stated 'double': a subpath starts with MOVETO, instead of MOVETO_OPEN, to state that it is closed, but it also ends with the closing line segment explicitly there. I tried with inkscape 0.46: input without explicit closing line, becomes output with explicit closing line (Inkscape 0.46 cannot output M0,0 1,0 1,1 0,1 z!) So actually, Inkscape used to output paths always with unnecessary closing segment! Maybe that is something to say in the release notes...
I think the way 0.46+devel works now is good: it maintains the explicit closing line; node editing however removes the explicit closing segment. (perhaps other operations as well, transforming does not remove it)
This whole issue popped up because I enabled path checking again in SPCurve (to see whether the old and new representations match up). So for closed paths, they don't anymore... but I think I can still safely start removing the old path code. A lot of places in Inkscape that are most often used are already using the new 2geom path exclusively, so... :-)
Even more off-topic: is there a 'line-counter' somewhere that shows a graph of the lines of code Inkscape's source has? (A bit more detailed than Ohloh's graph)
Cheers, Johan