On Mon, 2019-02-11 at 15:14 +0000, Alex Valavanis wrote:
Hi Tav and devs,

I'm currently looking into getting rid of the deprecated GtkAction usage in the TextToolbar.  It seems that the only sticking point is the use of the Ink_ComboBoxEntry_Action widget to select fonts.

It should be OK to migrate this to a Gtk::ToolItem, but before I do that, I just wondered if we had considered using the standard GtkFontButton (https://developer.gnome.org/gtk3/stable/GtkFontButton.html)?

This would provide a summary of the font face and size, but would pop-up a font-chooser dialog (https://developer.gnome.org/gtkmm-tutorial/stable/sec-font-chooser-dialog.html.en) rather than providing an entry in a combobox.  This could result in a less cluttered toolbar, but I suspect there might be some "clever things" going on in our font support, and I don't want to break anything without asking!

Any thoughts?

Our font selector has a lot of custom features that are incompatible with the standard font selector. It will indicate when fonts in the SVG are not locally available. It handles CSS font fallback lists. It displays fonts that are used in an SVG file at the top. It has a customizable font preview. Might be one or two things I've forgotten. It would be difficult to replace this functionality with the standard Gtk font button.