On Sat, Aug 1, 2009 at 6:55 PM, the Adib
<theadib@...2219...9...> wrote:
Hello Chris,
regarding the uninstall; it should do following tasks:
- delete the files that where installed
- let the user choose for changed files
- do not delete user created files
I picked up that much from the installer.
in the past 0.46 time the uninstaller removed all the files from the
install directory (delete *.*). There where a few problems.
- one user installed on c:\Program Files instead C:\Program
Files\Inkscape ; very bad uninstall
- some user add templates
- some user changed the templates
- you need to detect file change not by date/size but by content
I found a script on the nsis site that addresses those problems using
the md5 sums. That script I modified and used it for the 0.46
uninstaller.
Yes, it takes a very long time. But I think it is worth to address the
problems above. Let me know how you can speed up the method.
The method used opens and closes the install log lots of times. Each time you open it, it scans the directory, and then when you close it, it scans it again and saves the diff. The whole process will be considerably faster if just done once at start and end. Currently also the MD5 creation is separate from that; it could be made more efficient by merging the two steps. I'm proposing a switch to CRC32 checksums purely for the reason of storage; it saves almost 9MB. I'm not sure what speed is like, but I would expect CRC32 to be faster as well, as it is a simpler routine, I understand.
Thanks again for your effort.
Don't think I'm doing this for you - when one sees something which needs fixing, ... ;-) :P
I do enjoy doing it though, this and the website stuff :-)