On Tue, 2014-01-21 at 17:42 +0100, Krzysztof Kosiński wrote:
- What if we edit 2 documents in one instance of Inkscape
Then there will be two sp-trees. It's a very minor issue at this point.
Are we supposed to display different contents of common.svg in windows for a.svg and b.svg, reflecting their different contents at opening time.
For now, yes.
or should the displayed content of common.svg change when the file content is modified on disk?
I'd reserve that kind of disk monitoring to a part 4 or 5 of the functionality. We understand what not having that does and can caveat for now. But eventually even the root document should be updated if it's changed on disk. Similar to the way gedit warns users of the same.
- Do not use GSList and GListin new code, ever.
Ah man, I just got it working with GSList and boost looks like a dogs breakfast of spaghetti code. Do I /have/ to use boost or can std::list do the job too? (not example in the code of boost::ptr_list, very unsafe to try and implement)
- If child_documents and parent_document are supposed to be private,
they should be called _child_documents and _parent_document.
public.
- Inkscape should detect cyclic references and display an error image
in the place of references back to the root document (e.g. the one being edited).
Yep, got that covered already.
Thanks for your great response Krzysztof, that GSList complaint especially :-)
Martin,