Re: [Inkscape-devel] Rewrite of style handling code, code review requested.

On 27-3-2014 16:01, Tavmjong Bah wrote:

Hi all,

I have rewritten most of the style handling code in style.h and style.cpp to use real C++ classes. I would like you all to review the code and give feedback. The code is available at:

lp:~inkscape.dev/inkscape/style

Some quick comments about all the bitfield usage:

1. style.h, lines135-

Don't use bitfields there. Simply use bool. Much less bugprone. I don't think there is any reason to use bitfields there.

2. style-internal.h

Have a look at the use of all bitfields there. A 1-bit bitfield to store some boolean value, I think is best replaced with a bool.

(can you run clang-format on the code? thanks!)

-Johan