20 Feb
2014
20 Feb
'14
7:12 p.m.
On Thu, 2014-02-20 at 18:58 +0100, Johan Engelen wrote:
Hi Martin, I'm sorry, I will revert commit 13045.
Why be sorry, everything I've written recently has been reverted. While I might be annoyed, it's not with your code review, just with myself.
- It contains a memleak
realpath allocates new memory if the second argument is NULL. In the added code, this memory is never freed.
Realpath is a serious concern for me. I spent two hours researching path normalisation in c++ only to discover that it's impossible because glib is insufficient. :-/
If it doesn't start behaving I will fork inkscape and rewrite it a proper language like python. ;-)
If you happen to know about a C++ path normalisation function, do let me know as it will save me an awful lot of time.
Martin,