-----Original Message----- From: Marco [mailto:mrcekets@...400...] Sent: maandag 28 april 2008 14:08 To: Engelen, J.B.C. (Johan); buliabyak@...400...; mental@...3... Cc: inkscape-devel@lists.sourceforge.net; lib2geom-devel@lists.sourceforge.net Subject: Re: [Inkscape-devel] [Lib2geom-devel] newSVGEllipticalArcimplementation merged intopath.h
On Mon, 28 Apr 2008 13:16:19 +0200, <J.B.C.Engelen@...1578...> wrote:
However, I think it is best if we add some sort of debug
flag so that
people can choose between throwing an exception or doing
an assert
(crash).
Do you mean a simple #ifdef DEBUG or an ad-hoc flag ? Something like ELLIPTICAL_ARC_DEBUG ?
I meant a global flag, that chooses how to expand the
exception throw
macros; not just for the elliptical arc implementation. So
2geom either
throws exceptions or does asserts.
#define LIB2GEOM_EXCEPTIONS // define to have 2geom throw
exceptions
instead of asserts
That's ok, however I was thinking that it would be better to have the conditional defined code in just one place. So what do you think of defining the throwXxxxYyyy macros in the following way:
Exactly what I meant :-)